BlueQuartzSoftware / BlueQuartzSoftware/DREAM3D
Properly implement floating point summation in FindShapes filter
Open
Bug
- Dominant language
- C++
- Stars
- 189
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
The FindShapes filter calculates the second order moments of objects by summing over all the voxels belonging to a Feature. These values are on the order of 10^9, and since many summations occur, the floating point errors accumulate. This can be an issue for special cases where an eigenvalue of the moment matrix should be 0 but ends up being slightly larger or greater than 0. A proper floating point summation approach, such as Kahan summation, should be implemented.
Contributor guide
Assessment
This issue has not been assessed yet.