BlueHuskyStudios / BlueHuskyStudios/DeadassSimpleMediaPlayer

Recursive directory walk has no cycle or depth guard

Open
#53 0 comments 0 reactions 0 assignees View on GitHub
Automatically found
Dominant language
Swift
Stars
0
Forks
3
Avg merge
2d 22h
Merged PRs (30d)
9

Description

`contentsOfDirectory(at:contentTypes:recursive:)` recurses with no visited-set and no depth cap. Your own doc comment warns "this can cause a crash if there are recursive folders such as symlinks" — and recursion is now the *default* path for folder import (`allowRecursion: true` in `ContentView`).

Rare via iOS file providers, but it's a stack-overflow crash rather than a graceful failure.

Contributor guide

Open the contributing guide

Research direction

Start at contentsOfDirectory(at:contentTypes:recursive:) and inspect the recursive folder-import path in ContentView, where allowRecursion is true by default. Exercise the walk with recursive folders or symlinks and verify traversal terminates safely without a stack-overflow crash.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.