Blockstream / Blockstream/price-oracle

Minor Cleanup

Open
#3 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
2
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Lines 32-33: I assume that the specification would handle fiat currencies with 2 *or fewer* decimal places by padding the end with zeroes? This would enable a price feed for JPY and KRW.

Line 83: I assume the reference to "`message`" should be to "`priceMessage`"?

Line 100: As "cents" is associated with USD, perhaps substitute "two decimal places"?

Line 102: Perhaps add "or other three-letter currency code" to allow for CNH or other "unofficial" currency codes?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.