Blockstream / Blockstream/green_android

Support using wget instead of curl in fetch_gdk_binaries.sh

Open
#111 1 comment 0 reactions 1 assignee Claimed by @ardier16 View on GitHub
enhancement
Dominant language
Kotlin
Stars
268
Forks
106
PR merge metrics
No merged PRs in 30d

Description

### Description
The fetch_gdk_binaries.sh script require the curl command in order to download files:
https://github.com/Blockstream/green_android/blob/cfa2ecff9ea53dc58ccfb83614961f84f4b4add2/app/fetch_gdk_binaries.sh#L19
https://github.com/Blockstream/green_android/blob/cfa2ecff9ea53dc58ccfb83614961f84f4b4add2/app/fetch_gdk_binaries.sh#L37
using curl or wget, whatever is available is better, alpine by default comes with wget command, thus no need to install additional package in order to build the app with precomopiled binaries.

### Expected behaviour

Running the fetch_gdk_binaries.sh script under alpine works without installing curl as wget used instead, curl can be used if it's available, just not mandatory if wget command alternative is available.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.