Blockstream / Blockstream/Jade

Improve UX for descriptor registration

Open
#142 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
496
Forks
127
PR merge metrics
No merged PRs in 30d

Description

While testing the Jade implementation in Liana wallet i notice 2 important points:
In miniscript descriptors it's forbiden to reuse a key w/ the same multipath, so in liana we change the multipath for each occurence (<0;1>, <2;3>, <4;5>, etc...) when a key is used in several conditions. Multipaths are displayed in the descriptor template while registering a descriptor on jade, that is what i expected:

![image](https://github.com/Blockstream/Jade/assets/124568858/566aed6e-6298-495b-9c34-06aca43629e2)

but multipath are also displayed while reviewing the keys:

![image](https://github.com/Blockstream/Jade/assets/124568858/0eecf039-b3a1-495a-96b3-e9e0ab49c4d0)

- it is unnecessary and add a lot more in what the user need to verify, in the picture example, each key(total 4 keys) is use 3 time in the descriptor, so i have to verify 12 keys where in fact there is only 4!

- the jade never notify the user which key it owns, but it should!

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.