BlockchainCommons / BlockchainCommons/bc-shamir
CodeQL warnings
- Dominant language
- C
- Stars
- 5
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I am using bc-shamir in an application I am writing to generate SSKR shares on Ledger hardware wallet devices: [SSKR Check](https://github.com/aido/app-sskr-check)
CodeQL is giving a couple of warnings about bc-shamir which maybe you would like to be aware of.
See here:
https://github.com/aido/app-sskr-check/security/code-scanning/11
or here:
https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/
https://github.com/BlockchainCommons/bc-shamir/blob/cc574cebb6cc201168df42fb09dfa4d99442c548/src/shamir.c#L142
and here:
https://github.com/aido/app-sskr-check/security/code-scanning/12
https://github.com/BlockchainCommons/bc-shamir/blob/cc574cebb6cc201168df42fb09dfa4d99442c548/src/shamir.c#L79
Contributor guide
Assessment
This issue has not been assessed yet.