Blizzard / Blizzard/s2protocol

recognizing co-op games

Open
#69 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
641
Forks
118
PR merge metrics
No merged PRs in 30d

Description

I ran this replay through s2protocol https://lotv.spawningtool.com/35674/download/ with `--initdata` and got the following result (some stuff removed just to get to the important snippet)

```
{
"m_syncLobbyState": {
"m_gameDescription": {
"m_maxRaces": 6,
"m_maxTeams": 4,
"m_hasExtensionMod": false,
"m_maxColors": 16,
"m_isBlizzardMap": true,
"m_gameOptions": {
"m_competitive": false,
"m_practice": false,
"m_lockTeams": true,
"m_amm": true,
"m_battleNet": true,
"m_fog": 0,
"m_noVictoryOrDefeat": false,
"m_heroDuplicatesAllowed": true,
"m_buildCoachEnabled": false,
"m_advancedSharedControl": false,
"m_cooperative": false,
"m_clientDebugFlags": 265,
"m_observers": 0,
"m_teamsTogether": false,
"m_randomRaces": false,
"m_userDifficulty": 1
},
"m_defaultDifficulty": 2,
"m_isCoopMode": false,
"m_mapFileName": "",
"m_defaultAIBuild": 0,
"m_gameType": 0,
"m_hasNonBlizzardExtensionMod": false,
"m_randomValue": 3559572045,
"m_maxObservers": 12,
"m_isRealtimeMode": false,
"m_maxUsers": 2,
"m_modFileSyncChecksum": 2822893348,
"m_mapSizeX": 208,
"m_maxPlayers": 4,
}
}
}
```

Note that although, this game was a coop game, it has both

```
["m_syncLobbyState"]["m_gameDescription"]["m_gameOptions"]["m_cooperative"] === false
["m_syncLobbyState"]["m_gameDescription"]["m_isCoopMode"] === false
```

I'm not sure how those would have been read incorrectly from the replay, which would indicate that it's in the replay file itself. Am I misinterpreting what those field are meant for, or were those incorrectly encoded on the replays?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.