Blizzard / Blizzard/s2protocol

Warped in units have no m_creatorUnitTagIndex and m_creatorUnitTagRecycle

Open
#118 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
641
Forks
118
PR merge metrics
No merged PRs in 30d

Description

Currently the tags `m_creatorUnitTagIndex` and `m_creatorUnitTagRecycle` are attached only to `NNet.Replay.Tracker.SUnitBornEvents`. However, warped in Gateway units are not in `NNet.Replay.Tracker.SUnitBornEvents`; they exist only in `NNet.Replay.Tracker.SUnitInitEvents`. So, there's no way to recover the Gateway from which they were built.

There are two solutions.

1. Add warped in units to the `NNet.Replay.Tracker.SUnitBornEvent` list.
2. Add the `m_creatorUnitTagIndex` and `m_creatorUnitTagRecycle` items to the `NNet.Replay.Tracker.SUnitInitEvent`

Any way to add that info?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.