Blizzard / Blizzard/s2client-api

`Test_snapshots` assertion error on line 52: Cannot find terran scv

Open
#315 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.7k
Forks
280
PR merge metrics
No merged PRs in 30d

Description

Issue
-----
Test_Snapshot raises assertion error on line 52 of `test_snapshot.cc` during the test class `TestSnapshot3`.

Setup
------
Visual Studio 2019.
Latest client (74741).
Latest master branch of s2client-api (including new protocols)

Comments
-----------
I'm attempting to fix the sc2api for the latest client.

I'm pretty sure the problem is in how the raw observation data is piped in and then used to update the unit-pool (lines 582--595 of `sc2-client.cc`).
For some reason, after the first two test cases have passed (where `ObservationImp->unit_pool_ member` is populated with a total of 5 neutral and allied units), during the update prior to calling TestSnapshop3, only one unit is put into that pool.

For reference, the observation unit test class `Test_observation_interface.cc` pass just fine (though there are problems transitioning between test suites, but that's for another day).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.