Blizzard / Blizzard/node-rdkafka

Question about LibrdKafkaError Interface

Open
#959 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
2.2k
Forks
403
PR merge metrics
No merged PRs in 30d

Description

Hi all - just upgrading noderdkafka from a rather old version, and noticed -

Looking at:
lib/error.js and

export interface LibrdKafkaError {
message: string;
code: number;
errno: number;
origin: string;
stack?: string;
isFatal?: boolean;
isRetriable?: boolean;
isTxnRequiresAbort?: boolean;
}

Why do we need to have both code and errno? Is this some sort of legacy compatibility?

Thanks

Contributor guide

Open the contributing guide

Research direction

Start by reading lib/error.js and the LibrdKafkaError interface, then trace the issue's referenced error fields through the surrounding binding code. Done means establishing and documenting why both code and errno exist, or identifying a clearly agreed API change; the issue currently names no tests or other entry points.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, kafka, node.js
Domain
api, backend
Issue type
Documentation
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.