Blizzard / Blizzard/heroprotocol

Bug: TimeOnPoint and TimeOnPayload appear to always be 0?

Open
#72 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
401
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Possibly related: #41

Was looking at a replay recently (dated 11/9) and saw that a player received the `Point Guard` award on Volskaya but had the `TimeOnPoint` stat recorded as 0. Similarly, saw a replay on Hanamura Temple (also from 11/9) that had completed objective phases, but all team members had `TimeOnPayload` recorded as 0.

Either these aren't the right stats to look at for these maps in `SScoreResultEvent`, or they're always 0. Would be good to have this data in there!

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by examining how SScoreResultEvent exposes TimeOnPoint and TimeOnPayload, using the Volskaya and Hanamura Temple replay examples described in the issue. Compare the behavior with the related discussion in #41 and determine whether the decoder is reading the wrong fields or omitting available data. Done means the relevant objective-time stats are correctly available when present.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.