Blizzard / Blizzard/heroprotocol

'SScoreResultEvent' Self Healing sometimes applying to Healing

Open
#29 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
401
Forks
77
PR merge metrics
No merged PRs in 30d

Description

It looks like Thrall's 'SelfHealing' values are duplicated into his 'Healing' field as well. In the few replays I've looked at, these values match eachother in each game

Chen also has some 'Healing', as well as 'SelfHealing'. In a couple games I looked at, his 'SelfHealing' was around 15000, and 'Healing' was around 1000. Perhaps one of his talents' 'SelfHealing' or shielding is applying to 'Healing'

Looks like 'Li-Ming' can also have 'Healing' - a very small 94 in one game

There may be others, this is all I've found for now. If this is unintended, could you fix where these values are applied in a future build?

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by locating the SScoreResultEvent decoding and the handling of SelfHealing and Healing, then compare replay results for Thrall, Chen, and Li-Ming. Done means unintended SelfHealing, shielding, or other values no longer appear in Healing while legitimate Healing remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.