BlauGroup / BlauGroup/NanoParticleTools

Simulation analysis incorrect: occurrences_per_atom

Open
#23 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
12
Forks
5
PR merge metrics
No merged PRs in 30d

Description

In the analysis, the `occurrences_per_atom` is incorrectly calculated. It should be calculated without division by `simulation time`.

In the meantime, this value can be easily obtained by multiplying the `dndt_per_atom` by `simulation_time`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.