Blankj / Blankj/AndroidUtilCode

SpanUtils.setClickSpan存在内存泄漏

Open
#1,581 3 comments 0 reactions 1 assignee Claimed by @Blankj View on GitHub
bug
Dominant language
Java
Stars
33.6k
Forks
10.6k
PR merge metrics
No merged PRs in 30d

Description

## 描述 Bug
SpanUtils.setClickSpan存在内存泄漏

## 相关代码
```java
public SpanUtils setClickSpan(@ColorInt final int color,
final boolean underlineText,
final View.OnClickListener listener) {
setMovementMethodIfNeed();
this.clickSpan = new ClickableSpan() {

@Override
public void updateDrawState(@NonNull TextPaint paint) {
paint.setColor(color);
paint.setUnderlineText(underlineText);
}

@Override
public void onClick(@NonNull View widget) {
if (listener != null) {
listener.onClick(widget);
}
}
};
return this;
}
```

## 修复代码 扩展`NoCopySpan`
```
public static class FixSpan extends ClickableSpan implements NoCopySpan {

@Override
public void onClick(@NonNull View widget) {

}

@Override
public void updateDrawState(TextPaint ds) {
super.updateDrawState(ds);
}

}

public SpanUtils setClickSpan(@ColorInt final int color,
final boolean underlineText,
final View.OnClickListener listener) {
setMovementMethodIfNeed();
this.clickSpan = new FixSpan() {

@Override
public void updateDrawState(@NonNull TextPaint paint) {
paint.setColor(color);
paint.setUnderlineText(underlineText);
}

@Override
public void onClick(@NonNull View widget) {
if (listener != null) {
listener.onClick(widget);
}
}
};
return this;
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.