BitgesellOfficial / BitgesellOfficial/bitgesell

test: Clean up tests `gettime` is outdated

Open Beginner friendly
#143 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
29
Forks
75
PR merge metrics
No merged PRs in 30d

Description

## Summary

The `gettime` test is outdated:

- It was originally added in Bitcoin Core to verify the time handling in the MinGW toolchain and detect 32-bit vs 64-bit mismatches. However, the code now relies on std::chrono::system_clock, making the original check unnecessary.
- Although `system_clock` could still return incorrect values, any such issue would likely affect all
- `GetTime<>` calls, not just those with second-level precision. Such errors would probably trigger signed integer overflows at nanosecond precision, which should either be caught by UBSan or by the assert(`ret > 0s`) check. If not, the issue would become obvious in the debug log at startup.

## Notes

- For now, the test is can be removed. Alternatively, it could be expanded to cover time handling more comprehensively and updated alongside the block header timestamp logic.
- However, since that timestamp won’t exceed the year 2106, this is already covered by the `_test_y2106` functional test.

Contributor guide

Open the contributing guide

Research direction

Search the test suite for the outdated `gettime` test and inspect the `_test_y2106` functional test mentioned in the issue. Confirm that the existing functional coverage makes the old check unnecessary, then remove or update the test as appropriate and run the affected tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.