BitgesellOfficial / BitgesellOfficial/bitgesell

Tests: Make -j$(nproc) command exits with error 1

Open
#139 3 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
C++
Stars
29
Forks
75
PR merge metrics
No merged PRs in 30d

Description

### Motivation

Running:
```sh
./autogen.sh
./configure
```
Exits with following error:

```sh
make[2]: *** No rule to make target 'minisketch/src/test.cpp', needed by 'minisketch/src/test-test.o'. Stop.
make[2]: *** Waiting for unfinished jobs....
CXX qt/test/test_BGL_qt-moc_wallettests.o
make[2]: Leaving directory '/home/nmurgor/c++/bitgesell/src'
make[1]: *** [Makefile:17827: all-recursive] Error 1
make[1]: Leaving directory '/home/nmurgor/c++/bitgesell/src'
make: *** [Makefile:817: all-recursive] Error 1
```

Using GCC/G++
OS: Ubuntu 22.04 LTS
```nmurgor@nmurgor:~$ g++ --version
g++ (Ubuntu 11.4.0-9ubuntu1) 11.4.0
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
```

### Possible solution

Possible to resolve by updating build system to correctly handle building tests for `minisketch` lib
@wu-emma I can take on this soon enough
Ty!

### Useful Skills

* Compiling Bitcoin Core from source
* Running the C++ unit tests and the Python functional tests
* ...

### Guidance for new contributors

Want to work on this issue?

For guidance on contributing, please read [CONTRIBUTING.md](https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md) before opening your pull request.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the failure with ./autogen.sh, ./configure, and make -j$(nproc), then inspect the build-system references to minisketch/src/test.cpp and the generated Makefiles. Confirm that the minisketch test target has a valid source dependency and that a parallel build completes successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.