Bitcoin-ABC / Bitcoin-ABC/bitcoin-abc

The archived source code is missing src/compat/setenv.h

Open
#297 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.3k
Forks
788
PR merge metrics
No merged PRs in 30d

Description

The archived source code, which can be found at https://download.bitcoinabc.org/0.18.5/linux/src/bitcoin-abc-0.18.5.tar.gz (which is the source code stripped of the github specific files/directories), is missing file src/compat/setenv.h

When compiling, this give error:

qt/test/test_main.cpp:9:10: fatal error: compat/setenv.h: No such file or directory
#include "compat/setenv.h"
^~~~~~~~~~~~~~~~~
compilation terminated.
Makefile:8895: recipe for target 'qt/test/qt_test_test_bitcoin_qt-test_main.o' failed

That was with version 0.18.5, but I suspect the issue is present also with older releases

As for the compile environment, I don't think this is really the issue here, but for info, this was compiled under Ubuntu 18.04 (native), gcc/g++ 0.7.3, on AMD Ryzen 2700X, 64GB RAM, 1TB NVMe.

The github release https://github.com/Bitcoin-ABC/bitcoin-abc/archive/v0.18.5.tar.gz does have this file. And copying the missing setenv.sh file to the extracted archived sources does make the compilation process succeed.

Regards,
Eric

Contributor guide

Open the contributing guide

Research direction

Compare the archived 0.18.5 source at the provided download URL with the GitHub release archive, focusing on src/compat/setenv.h. Reproduce the failure by building the qt test target that includes qt/test/test_main.cpp; done when the archived source contains the required header and compilation succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system, release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.