BioSTEAMDevelopmentGroup / BioSTEAMDevelopmentGroup/Bioindustrial-Park

Consultation about investment_site_factors

Open
#143 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
53
Forks
27
PR merge metrics
No merged PRs in 30d

Description

a) Hello, could I consult you how to use ```investment_site_factors```? I use ```investment_site_factors``` in the following code, but ```TypeError: CellulosicEthanolTEA.__init__() got an unexpected keyword argument 'investment_site_factors'``` will be reported.
```
class TEA(CellulosicEthanolTEA):
_TCI_ratio_cached = 1
def create_tea(sys, OSBL_units=None, cls=None):
if OSBL_units is None: OSBL_units = bst.get_OSBL(sys.cost_units)
try:
BT = tmo.utils.get_instance(OSBL_units, (bst.BoilerTurbogenerator, bst.Boiler))
except:
BT = None
if cls is None: cls = TEA
tea = cls(
system=sys,
IRR=0.10,
duration=(2007, 2037),
depreciation='MACRS7',
income_tax=0.35,
operating_days=0.9*365,
lang_factor=None,
construction_schedule=(0.08, 0.60, 0.32),
startup_months=3,
startup_FOCfrac=1,
startup_salesfrac=0.5,
startup_VOCfrac=0.75,
WC_over_FCI=0.05,
finance_interest=0.08,
finance_years=10,
finance_fraction=0.4,
OSBL_units=OSBL_units,
warehouse=0.04,
site_development=0.09,
additional_piping=0.045,
proratable_costs=0.10,
field_expenses=0.10,
construction=0.20,
contingency=0.10,
other_indirect_costs=0.10,
labor_cost=2.5e6,
labor_burden=0.90,
property_insurance=0.007,
maintenance=0.03,
steam_power_depreciation='MACRS20',
boiler_turbogenerator=BT,
investment_site_factors=0.83)
return tea
```

b) In addition, there seems to be no Chinese ```investment_site_factor``` in the tutorial (https://biosteam.readthedocs.io/en/latest/API/TEA.html#:~:text=investment_site_factors%3A%20dict%5Bstr%2C%20float%5D%20%3D%20%7B%27India%27%3A%200.85%2C%20%27Japan%27%3A%201.15%2C%20%27Mexico%27%3A%200.95%2C%20%27Pacific%20Rim%27%3A%201.0%2C%20%27U.S.%20Gulf%20Coast%27%3A%201.0%2C%20%27U.S.%20Midwest%27%3A%201.15%2C%20%27U.S.%20Northwest%27%3A%201.1%2C%20%27U.S.%20Southwest%27%3A%200.95%2C%20%27U.S.%20West%20Coast%27%3A%201.25%2C%20%27Western%20Europe%27%3A%201.2%7D), it should be ```0.83```, could you please add it to the source code?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the CellulosicEthanolTEA.__init__ entry point and compare its accepted arguments with the investment_site_factors API shown in the linked TEA tutorial. Verify how the country factors are defined, then update the source and tutorial so the keyword and the requested China value are represented consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design, documentation
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.