BioSTEAMDevelopmentGroup / BioSTEAMDevelopmentGroup/Bioindustrial-Park

Boiler source code unit Settings

Open
#142 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
53
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Hello, the unit Settings in the boiler source code seem to have some problems (https://github.com/BioSTEAMDevelopmentGroup/biosteam/blob/master/biosteam/facilities/_boiler_turbogenerator.py#L338), ```H_content``` is in ```kJ/h```, ```duty_over_mol``` is in ```kJ/mol```, so ```self.total_steam``` should be in ```mol/h```, but written in ```kmol/h``` (https://github.com/BioSTEAMDevelopmentGroup/biosteam/blob/master/biosteam/facilities/_boiler_turbogenerator.py#L337)?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.