BioPhoton / BioPhoton/angular-star-rating

Half star doesn't work after upgrading to Angular v16

Open
#128 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
219
Forks
82
PR merge metrics
No merged PRs in 30d

Description

**Half star doesn't work after upgrading to Angular v16**,
[[this](https://github.com/BioPhoton/angular-star-rating/commit/7870caaea5777aa0c359a1052fba1d1432e981bc#diff-ac5abcc48a7515b295fa7d1602ba3bd1cef4953c8e936903e119e1879f94475fR16-R19)] change breaks the logic related to half star showing - [[check the logic](https://github.com/duxor/angular-star-rating/blob/master/libs/angular-star-rating/src/lib/services/star-rating.ts#L420)].

**Minimal reproduction of the problem with instructions**

I added workaround as well:

[https://stackblitz.com/edit/stackblitz-starters-vn2jtb?file=src%2Fmain.ts](https://stackblitz.com/edit/stackblitz-starters-vn2jtb?file=src%2Fmain.ts)

**Versions**

- `@angular/core`: 17.0.0
- `rxjs`: 7.8.0
- `angular-star-rating`: 7.0.0
- `css-star-rating`: 1.3.1

Browser name and version:

- [ ] Chrome (desktop) version any

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.