BikeNetKit / BikeNetKit/GrowBikeNet

Test main should use assert_frame_equal, not equals

Open
#235 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
7
Forks
4
Avg merge
4h 4m
Merged PRs (30d)
32

Description

Using equals does nothing, so the tests are actually failing.
We will have to re-run all the validation frames.
I just tried one, and running the same code in test_main as in development.py creates very different data exports. There must be some issue with the version - I don't understand yet. Probably related to #234

For example, test_growbikenet_case_success_offline_import_data3:

Output from development, using exact same code and import data: 321 rows

Image

Output from test_growbikenet_case_success_offline_import_data3: 408 rows

Image

Contributor guide

Open the contributing guide

Research direction

Start in test_main at test_growbikenet_case_success_offline_import_data3 and compare its validation with the corresponding code in development.py. Replace the ineffective equality check with the requested frame comparison, then re-run the validation frames and investigate why the test produces 408 rows instead of 321. Done means the comparison detects mismatches and the export discrepancy is understood.

Written by the indexing model from the issue text.

Assessment

Tech stack
pandas, python
Domain
data, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.