BetterErrors / BetterErrors/better_errors

Needs smoke tests

Open
#484 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Ruby
Stars
6.9k
Forks
430
PR merge metrics
No merged PRs in 30d

Description

#480 and #481 fixed an issue that I introduced by referring to a constant that wasn't loaded yet.

CI didn't fail, even though every app failed the moment it tried to load.

I think the solution here is to add a smoke test that runs an app of some kind (Rails/Sinatra/pure Rack) and make sure the app starts. This actually might be more effective than all of the specs we have, which currently have to cover a lot of different cases (with Rails, each version of rails, etc).

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.