BeaconCMS / BeaconCMS/beacon_live_admin

Support gettext ~> 1.0 for Phoenix 1.8 compatibility

Open
#417 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
73
Forks
35
PR merge metrics
No merged PRs in 30d

Description

beacon_live_admin's `mix.exs` specifies `{:gettext, "~> 0.26"}`, which prevents installation in Phoenix 1.8 projects that require `{:gettext, "~> 1.0"}`.

The fix is trivial — the codebase already uses the gettext 1.0-compatible API everywhere (`use Gettext.Backend` and `use Gettext, backend: ...`).

The only change needed is in `mix.exs`:

```diff
- {:gettext, "~> 0.26"},
+ {:gettext, "~> 0.26 or ~> 1.0"},
```

Closes https://github.com/BeaconCMS/beacon/issues/859 (same issue in beacon)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.