BeaconCMS / BeaconCMS/beacon

Support partial segments on paths

Open
#161 0 comments 0 reactions 0 assignees View on GitHub
area:loader enhancement
Dominant language
Elixir
Stars
1.3k
Forks
134
PR merge metrics
No merged PRs in 30d

Description

Beacon has to support all path formats supported by upstream Phoenix and currently it's missing support for partial segments like `/my-page/v:version`

Every page is stored on a ETS table when it's loaded and that's the source to lookup for pages when a request comes in. Example, a request to `/blog/my-first-post` will try to match `/blog/my-first-post` or `/blog/*` or any other rule to find the matching `%Page{}`

That logic is implemented at https://github.com/BeaconCMS/beacon/blob/7790eb72769a026c0bdfc3167aab394a9b73ce91/lib/beacon/router.ex#L354 and that's where we need to add support for partial segments.

Also important to double check:
- Allow creating pages with such partial segments
- Resolve beacon_path_params

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.