BattletechModders / BattletechModders/MechEngineer
Multiply engine weight factors
Open
- Dominant language
- C#
- Stars
- 15
- Forks
- 20
- PR merge metrics
- No merged PRs in 30d
Description
#123 mentions that multiple weight factors are added together. They should be multiplied together. For an XL engine with a supercharger, the final weight should be 0.5 (XL is half the weight) times 1.1 (supercharger adds 10%) which equals 0.55, not 0.6 which is what it currently produces.
The difference is greater with XXL engines. Should be 0.36666 but instead has 0.43333. You should just be able to change
`EngineFactor += savings.EngineFactor - 1;`
to
`EngineFactor *= savings.EngineFactor;`
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.