BattletechModders / BattletechModders/MechEngineer

CB/CAC compatibilty issues

Open
#206 0 comments 0 reactions 1 assignee Claimed by @CptMoore View on GitHub
Dominant language
C#
Stars
15
Forks
20
PR merge metrics
No merged PRs in 30d

Description

1. try to fix the issue (keep away from transpilers, make sure to patch methods still called by CB)
2. if not fixable, discuss where is precedence (usually CAC) and disable code by config (e.g. fake_vehicle tag to disable some checks)
3. if no precedence, migrate code to or have new implementation in CAC, and disable code here (e.g. hardpoint fix)

TODOs:
- detect if CB/CAC is enabled and if so: disable hardpoint fix
- in CAC `NullifyDestoryedLocationDamage` is by default true, RT makes it false so ComponentExplosions properly propagate:
- Detect CAC and warn if config is true, or force it false

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.