BattletechModders / BattletechModders/LootMagnet

Math errors

Open
#20 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
11
Forks
3
PR merge metrics
No merged PRs in 30d

Description

From nexus:

I noticed another issue while looking at the logs, mod description, and rules file. Dunno if you'd want this as a separate bug report or not, but it seems that LootMagnet has a small math error in picking values from the RollupMRBValue array. My company is rated 4 stars, and with MRB ratings going 0 to 5 stars that should make it the fifth value or 180,000, but LootMagnet has been using the fourth value, 130,000, instead.

Edit: Also, it seems like weapons and mech parts aren't having their Claimed Salvage values properly reflected due to increased quantities. 7 medium lasers shows up as 60k not 420k, and I saw the same issue with the Vulcan pieces where a "QTY: 2" has the same Claimed Salvage value as a single piece. On the other hand 21 heat sinks show up as 630,000 Claimed Salvage, not 30,000.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by checking how LootMagnet selects values from the RollupMRBValue array and how Claimed Salvage is calculated for weapons and mech parts. Compare the implementation with the logs, mod description, and rules file mentioned in the report. Done means four-star companies use the fifth value and salvage quantities are reflected consistently for the reported examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.