BattletechModders / BattletechModders/IRTweaks

Prevent TurnDirectory.StartFirstRound from firing multiple times

Open
#62 1 comment 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
C#
Stars
8
Forks
12
PR merge metrics
No merged PRs in 30d

Description

There appears to be a bug with the MissionControl (maybe?) implementation of additional lances. When the dropship lands, it looks like it invokes TurnDirector.OnDropshipAnimationComplete which ultimately ends up calling TurnDirector.StartFirstRound. This can lead to the round 'starting' multiple times.

We need to put a gate in on TurnDirector.StartFirstRound() to do nothing is GameHasBegun = true. Fix should be named something like 'PreventMultipleFirstRoundStarts'?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing TurnDirector.OnDropshipAnimationComplete into TurnDirector.StartFirstRound and inspect how MissionControl handles additional lances. Verify the existing GameHasBegun state and ensure repeated first-round triggers are ignored; done means the first round starts only once.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.