BattletechModders / BattletechModders/CustomSalvage
UpgradeSalvage = true ignores blacklist
Open
- Dominant language
- C#
- Stars
- 2
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Description
AddComponentToPotentialSalvage in source/ContractHelpers.cs doesn't have any logic to avoid blacklisted items when it gets to the upgrading portion of code e.g. lines 172 and 201.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in source/ContractHelpers.cs at AddComponentToPotentialSalvage, especially the upgrading code around lines 172 and 201. Trace how blacklist checks are handled before and during upgrading, then verify that UpgradeSalvage = true does not add blacklisted items to potential salvage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100