Baseflow / Baseflow/flutter_cached_network_image

errorWidget should be called errorWidgetBuilder

Open
#334 0 comments 0 reactions 0 assignees View on GitHub
type: enhancement
Dominant language
Dart
Stars
2.6k
Forks
731
Avg merge
3d 9h
Merged PRs (30d)
1

Description

`placeholder` reads like it expects a widget, `errorWidget` reeeally sound like I should provide a `Widget`, but no, they are both `Builders`, so they should be renamed to `placeholderBuilder` and `errorBuilder`, or there should be `placeholder` and `errorWidget` that accepts a `Widget` and leave the other to be builders, the way it is right now is confusing.

Also, `errorWidget` is of type `LoadingErrorWidgetBuilder`, Loading is just unnecessary, and the `placeholder` type doesn't have a "Loading" on its name, which is inconsistent.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.