Baseflow / Baseflow/XamarinMediaManager

In UWP the aspect ratio of the video is not correctly adjusted (Xamarin.Forms)

Open
#829 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
763
Forks
299
PR merge metrics
No merged PRs in 30d

Description

## 🐛 Bug Report
When I add the video player with a custom width and height on a page the video aspect ratio does not fit correctly to the indicated size causing the video controls to hide, this only happens in UWP.

### Expected behavior
In case of using a custom width and height, the video player in UWP must correctly adjust the aspect ratio of the video without losing the video controls.

### Reproduction steps
I have uploaded a repository where you can see the problem: https://github.com/nacompllo/MediaManagerUWPIssue

**In UWP the aspect ratio of the video is not correctly adjusted to the indicated size and the video controls are lost.**

![MediaManagerUWPIssue UWP 31_07_2021 16_29_45](https://user-images.githubusercontent.com/20904914/127743445-f8bcc119-c685-44a9-bd43-ba0b72a10c4c.png)

### Configuration
Plugin.MediaManager.Forms 1.0.9
Xamarin.Forms 5.0.0.2083

**Platform:**
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [x] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [x] :monkey: Xamarin.Forms

Contributor guide

Open the contributing guide

Research direction

Start with the linked MediaManagerUWPIssue reproduction repository and the UWP video-player implementation in XamarinMediaManager. Reproduce the custom-width and custom-height case on UWP, then trace how sizing affects the aspect ratio and video controls. Done means the video fits the indicated dimensions without hiding its controls.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
desktop-dev, mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.