Baseflow / Baseflow/Xamarin-Sidebar

Bug in SidebarController.IsOpen

Open
#41 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
112
Forks
67
PR merge metrics
No merged PRs in 30d

Description

Looks like the code has the sense of the boolean inverted. If I set `IsOpen= true`, the menu should open, not close.

```
public bool IsOpen
{
get { return _sidebar.IsOpen; }
set
{
_sidebar.IsOpen = value;
if (_sidebar.IsOpen)
CloseMenu();
else
OpenMenu();
}
}
```

Also, setting `_sidebar.IsOpen` prevents the opening. So the code should simply read:

```
public bool IsOpen
{
get { return _sidebar.IsOpen; }
set
{
if (value)
_sidebar.OpenMenu();
else
_sidebar.CloseMenu();
}
}
```

Is this correct?

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.