Baseflow / Baseflow/PhotoView

Way to get location of tap outside view?

Open
#823 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
18.8k
Forks
3.9k
PR merge metrics
No merged PRs in 30d

Description

I am looking at OnOutsidePhotoTapListener and `void onOutsidePhotoTap(ImageView imageView);`:

https://github.com/Baseflow/PhotoView/blob/master/photoview/src/main/java/com/github/chrisbanes/photoview/OnOutsidePhotoTapListener.java

## 🚀 Feature Requests

This callback appears to only say what ImageView the tap was outside of but not where it was.

### Contextualize the feature / Describe the feature.

It would be useful to get, if not the exact location of the tap, the nearest point *to* the tap. As it is, if the user is trying to tap on a point on the edge of the photo view they might have to try several times accidentally tapping on the wrong side of the border.

Expected behavior, if this is possible: onOutsidePhotoTap should have the same signature as `void onPhotoTap(ImageView view, float x, float y);`. The coordinates returned should (probably) be clamped to the range 0..1, 0..1.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.