Baseflow / Baseflow/PhotoView

scaleType can not be set when zoomable is set to false

Open
#583 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
18.8k
Forks
3.9k
PR merge metrics
No merged PRs in 30d

Description

Creating a `PhotoView` and setting the zoomable property to false works as expected but it is not possible to change the scaleType anymore. It has no affect and is always FIT_CENTER.

Diving into the attacher it becomes obvious that the update method resets the scaleType when zoomable is false and does not update the base matrix with the new scaleType. https://github.com/chrisbanes/PhotoView/blob/master/photoview/src/main/java/com/github/chrisbanes/photoview/PhotoViewAttacher.java#L513

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.