Baseflow / Baseflow/PhotoView

onMatrixChanged() flawed?

Open
#171 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
18.8k
Forks
3.9k
PR merge metrics
No merged PRs in 30d

Description

It calls getDisplayRect() to calculate the display rectangle which in turn uses the drawable intrinsic dimensions. This seems flawed to me. When I try, for instance, with a 700 pixel wide image, I get displayRect.right values well above 1,000 which is clearly wrong. I'll report back with some suggestions shortly but at first sight, the most obvious change would be to map the currently visible rectangle instead of the whole drawable to start with.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.