Baseflow / Baseflow/LottieXamarin

Active dependency issue causing app store submission to fail on UWP

Open
#346 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.2k
Forks
253
PR merge metrics
No merged PRs in 30d

Description

## 🐛 Bug Report

Not sure if this is the right place to post this but here is what is going:

Active dependency issue causing app store submission to fail on UWP (here is the UWP app store submission error):
- Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
- The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.ILottieVisualSourceClass in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.
- Parameter value of method add_AnimatedVisualInvalidated of type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd references the non-Windows Runtime type Microsoft.UI.Xaml.Controls.IDynamicAnimatedVisualSource. Windows Runtime types can reference only Windows Runtime types.
- The type Microsoft.UI.Xaml.Controls.IAnimatedVisual referenced by type Microsoft.Toolkit.Uwp.UI.Lottie.LottieVisualSource in file Microsoft.Toolkit.Uwp.UI.Lottie.winmd was not found. All types referenced in metadata files must be discoverable.

Here is what I've been able to find:
"com.airbnb.xamarin.forms.lottie" has a dependency on "microsoft.toolkit.uwp.ui.lottie" and that has a dependency on "Microsoft.UI.Xaml".

There is an active issue being tracked for "Microsoft.UI.Xaml" that seems to be the cause of our failed app store submissions:
https://github.com/microsoft/microsoft-ui-xaml/issues/5298

I wanted to point this out because I believe that you will need to update your dependencies when fix is out.

Thanks!

### Expected behavior

### Reproduction steps

### Configuration

**Version:** 1.x

**Platform:**
- [ ] :iphone: iOS
- [ ] :robot: Android
- [ ] :checkered_flag: WPF
- [X] :earth_americas: UWP
- [ ] :apple: MacOS
- [ ] :tv: tvOS
- [ ] :monkey: Xamarin.Forms

Contributor guide

Open the contributing guide

Research direction

Review the dependency chain from com.airbnb.xamarin.forms.lottie through microsoft.toolkit.uwp.ui.lottie and Microsoft.UI.Xaml, then read the referenced microsoft-ui-xaml issue 5298. Confirm which dependency version resolves the reported UWP metadata errors and verify that an affected UWP app can pass store submission without those errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.