BabylonJS / BabylonJS/BabylonNative

Need a validation test for depth prepass.

Open
#778 3 comments 0 reactions 1 assignee Claimed by @CedricGuillemet View on GitHub
testing
Dominant language
C++
Stars
919
Forks
162
Avg merge
1d 15h
Merged PRs (30d)
19

Description

It was recently discovered (https://github.com/BabylonJS/Babylon.js/pull/10466) that the [`needDepthPrePass`](https://doc.babylonjs.com/typedoc/classes/babylon.material#needdepthprepass) material property was causing the depth buffer to block the following opaque/color rendering step. We should consider adding a validation test to make sure this isn't broken in the future.

[The relevant code in renderingGroup.ts](https://github.com/BabylonJS/Babylon.js/blob/d120c8e483e3e92f01deba34880552be27bfaed8/src/Rendering/renderingGroup.ts#L353-L367)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.