BabylonJS / BabylonJS/BabylonNative

Replace Napi methods with properties where possible

Open
#1,010 1 comment 2 reactions 0 assignees View on GitHub
performance
Dominant language
C++
Stars
919
Forks
162
Avg merge
1d 15h
Merged PRs (30d)
19

Description

Methods like `NativeEngine::GetRenderWidth` start to appear in CDT profiling. It's called (at least) once per frame even with that few calls, it's slow enough to rise in the top methods.
(https://github.com/BabylonJS/BabylonNative/blob/4fd6df8541c5bc0ae98a9db7879917f46dbc0eb2/Plugins/NativeEngine/Source/NativeEngine.cpp#L1484)

Replace with properties anywhere possible. Only update the napi value when it changes.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.