BHoM / BHoM/XML_Toolkit

Translucent shades as shading elements to gbXML

Open
#548 0 comments 0 reactions 2 assignees Claimed by @EKAdebo View on GitHub
size:M type:feature
Dominant language
C#
Stars
9
Forks
3
Avg merge
2d 17h
Merged PRs (30d)
1

Description

In the following PR, the XML TK was updated to changes to the FilterPanelsByType method, which now accepts a list of panel types to filter.
https://github.com/BHoM/XML_Toolkit/pull/547/files

In this file, there are four instances of
`(new List() { PanelType.Shade })`

These should each be replaced with
`(new List() { PanelType.Shade, PanelType.TranslucentShade })`

These changes will (most probably) allow TranslucentShades to be treated as regular shades once converted to gbXML. It would be better if we could preserve their translucent status. We will need to check the gbXML documentation for whether translucent panels are supported in the format, and then implement this - one way to do this might be to modify the Panel.ToGBXMLShade method.

This will also need testing.
- Build in VS
- Then load Rhino/GH, and generate some test geometry. This test geometry should include a standard space (a shoebox with 4 walls, roof and floor), a Panel with type Shade and a Panel with type TranslucentShade.
- Then, push this geometry to GBXML

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.