BHoM / BHoM/Revit_Toolkit

Make sure the warnings are raised appropriately

Open
#400 4 comments 0 reactions 1 assignee Assigned to @pawelbaran View on GitHub
type:bug type:question
Dominant language
C#
Stars
35
Forks
16
Avg merge
7d 29m
Merged PRs (30d)
2

Description

#### Description:
Currently every warning/error event generates a new item in the reflection stack. This results in hundreds of similar warnings being exposed to the user, which makes them tl;dr.

#### How to replicate:
Pull 100 elements with material _By Category_ with GH - only 15 first unknown material warnings will be seen.

#### Expected behaviour:
My idea is as follows: one warning per issue, then optionally supplement the message with a list of ElementIds/BHoM_GUIDs?

@FraserGreenroyd @adecler @al-fisher would it be possible to buffer the duplicate warnings (_almost_ duplicate: same issue but different ElementId or BHoM_GUID) in Reflection and format the warning message on the UI end, or should they be stored on Revit_Toolkit side and formatted before calling `BH.Engine.Reflection.Compute.RecordWarning`?

Self-reminder:
- resolve #820 into account when working on it

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.