BHoM / BHoM/Revit_Toolkit

Revit diffing: shouldn't RevitPulledParametersDifferences take unit and quantity into account?

Open
#1,564 0 comments 0 reactions 3 assignees Claimed by @vietle-bh View on GitHub
type:bug type:question
Dominant language
C#
Stars
35
Forks
16
Avg merge
7d 29m
Merged PRs (30d)
2

Description

#### Description:

Currently Revit parameters are considered the same if their value is the same:
https://github.com/BHoM/Revit_Toolkit/blob/890faab6edcd210bf0b4247bad34f37aaa4ecb62/Revit_Engine/Query/RevitPulledParametersDifferences.cs#L118-L119

However, there are also properties like `Quantity`, `Unit` and `IsReadOnly` - a bit on the fence whether they shouldn't also be checked for equality?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.