BHoM / BHoM/Revit_Toolkit

Inconsistent Return Type (FamilyType vs. ModelInstance) in pull request with FilterByCategory() [BHOM Excel]

Open
#1,522 2 comments 0 reactions 0 assignees View on GitHub
type:bug
Dominant language
C#
Stars
35
Forks
16
Avg merge
7d 29m
Merged PRs (30d)
2

Description

#### Description:
When using BHOM from Excel to extract Air Terminal instances from a Revit model, I notice that objects belonging to different Air Terminal families are returned as ModelInstance objects. However, within those ModelInstance objects, a FamilyType appears to be stored as InstanceProperties. The ObjectFromRevit descriptions suggests that an object can be one of three types (BHoMObject, ModelInstance, or DraftingInstance), but it seems like the FamilyType is being handled differently.
![image](https://github.com/user-attachments/assets/af90edf3-2f3f-4fb6-b36f-a3ccd2999a58)

#### Expected behaviour:
From description of ObjectFromRevit, It was expected to return one of three types:
- BHoMObject for FamilyType
- ModelInstance for FamilyInstance
- DraftingInstance for ViewSpecific Instance

I suspect this initiation store a FamilyType as an InstanceProperties in the caches as the function working on a ModelInstance
![image](https://github.com/user-attachments/assets/182105a0-1f69-47f5-ac85-1688db6ff375)

Am I misunderstanding the BHOM data structure, or is this a bug in how BHOM is interpreting Revit families?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.