BHoM / BHoM/Revit_Toolkit

Edge case error on convert from Revit roof to structural panel

Open
#1,287 1 comment 0 reactions 1 assignee Claimed by @pawelbaran View on GitHub
type:bug
Dominant language
C#
Stars
35
Forks
16
Avg merge
7d 29m
Merged PRs (30d)
2

Description

#### Description:

Following [this comment](https://github.com/BHoM/Revit_Toolkit/pull/1285#issuecomment-1346247091) by @vietle-bh, an error occurs on pull of the roof below from the standard test file.

![image](https://user-images.githubusercontent.com/102604891/207023930-e4fd5a63-fa31-4c0b-a5c5-43e2b1d7f2dc.png)

The bottom of the issue lies in the fact that `BH.Engine.Structure.Create.Panel` method does not take geometrical tolerance as input, causing the Revit outline to be considered as not closed (even though it is acc. to Revit). Issue on BHoM_Engine raised under https://github.com/BHoM/BHoM_Engine/issues/2961 - once it gets resolved, Revit tolerance will need to be passed in the line below (and in all other panel creation calls).

https://github.com/BHoM/Revit_Toolkit/blob/3c0ec5027b00253680b39f5c5dcf52e581dde5b7/Revit_Core_Engine/Convert/Structure/FromRevit/Panels.cs#L140

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.