Revit_Core_Engine: Diffing MEP elements failed due to location curve split
- Dominant language
- C#
- Stars
- 35
- Forks
- 16
- Avg merge
- 7d 29m
- Merged PRs (30d)
- 2
Description
I noticed that diffing MEP elements such as ducts would often fail. This is because things like a duct will possibly be exported as multiple objects with the same Guid to handle the case below.
https://github.com/BHoM/Revit_Toolkit/blob/15cfcd06a0f99ac02691f29ff175932ec595cf93/Revit_Core_Engine/Query/LocationCurve.cs#L163-L169
In this scenario, a diff will return null at this check...
https://github.com/BHoM/BHoM_Engine/blob/bdde55560efd5460930a858b4a5c1c9392f893e0/Diffing_Engine/Compute/DiffWithCustomIds.cs#L110-L111
... which means Revit isn't too happy:
Should we make it so all diffing called from Revit have `diffingConfig.AllowDuplicateIds` set to True?
Or, will we never diff MEP elements so this shouldn't be an issue?
Contributor guide
Assessment
This issue has not been assessed yet.