BHoM / BHoM/Psychrometrics_Toolkit

SpecificHeatCapacityWater output unit check

Open
#102 0 comments 0 reactions 0 assignees View on GitHub
type:compliance
Dominant language
C#
Stars
2
Forks
1
Avg merge
2d 17h
Merged PRs (30d)
1

Description

#### Broken rules:
This method output unit is kJ/kgK, which is not SI.

I have given this compliance check its own issue, as it will require a bit of work to see if there are any knock-on effects of adjusting the output for SI/BHoM compliance.

#### Suggestions to restore compliance:
Check for any knock-on effects of fixing this method. If acceptable to fix, then multiply output by 1000 and update output attribute.

Contributor guide

Open the contributing guide

Research direction

Start at the SpecificHeatCapacityWater method and inspect its output attribute and all usages to identify possible knock-on effects. Confirm whether changing the output to SI units is acceptable, then update the value and attribute only if affected consumers remain correct; verify the relevant existing checks or tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.