BHoM / BHoM/PowerPoint_Toolkit
Refactor PowerPointAdapter to use ActionConfig
- Dominant language
- C#
- Stars
- 1
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
#### Broken rules:
As with other adapters, all actions should use an action config to determine the template and output files (see [IES_Toolkit](https://github.com/BHoM/IES_Toolkit)). This would allow an adapter to use different template/output files without re-instantiating the adapter with different parameters.
#### Suggestions to restore compliance:
Remove constructors that accept `FileSettings` and `Stream` inputs, and create `ActionConfig`s for these scenarios. Then modify existing actions to use the action configs instead of the private FileSettings/Stream properties. This would also make determining the actions to use (file settings vs stream usage).
This is by definition a breaking change, so versioning will be required, and ensure to update affected toolkits.
Contributor guide
Assessment
This issue has not been assessed yet.