BHoM / BHoM/Lusas_Toolkit

When a Loadcase does not have an AdapterId the Create crashes

Open
#392 0 comments 0 reactions 0 assignees View on GitHub
type:bug
Dominant language
C#
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

#### Description:

Quite a niche case when the `Loadcase.Number` is the same, but the names are different. The name is reassigned but the `AdapterId` is not.

#### Steps to reproduce:

See test script.

#### Expected behaviour:

The `AdapterId` should be assigned, there should also be a check downstream that looks at the `AdapterId` and the `LoadcaseId` if they do not exist, to return an error rather than exception.

#### Test file(s):

https://burohappold.sharepoint.com/:f:/s/BHoM/Eghq8HuCT3FLvUSO992AdQQBT_SYE8jGp24vlmoyyF6VRw?e=yY7zYe

Contributor guide

Open the contributing guide

Research direction

Start with the linked test script and trace the Create path for a Loadcase whose Number is reused under a different name. Verify the fix by checking that AdapterId is assigned and that downstream handling of missing AdapterId or LoadcaseId returns an error rather than throwing an exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.