BHoM / BHoM/Lusas_Toolkit

Convert method naming convention

Open
#222 2 comments 0 reactions 1 assignee Claimed by @KalleEdstroem View on GitHub
severity:low size:S type:compliance
Dominant language
C#
Stars
3
Forks
2
PR merge metrics
No merged PRs in 30d

Description

#### Broken rules:

Current naming convention is `ToBar`, `ToPoint`, `ToBarDistributedLoad `etc.

#### Suggestions to restore compliance:

Change method names for `Convert `to `FromLusas`

We ran in to this problem before, because Lusas stores all loads under a single class `IFLoading`, therefore all `Convert `methods for loads would have the same input parameters leading to compiling errors. Therefore, we broke all Convert methods down to `ToBarPointLoad`, `ToAreaUniformlyDistributed `etc.

So instead of using FromLusas we could be specific:
- `FromLusasPoint`
- `FromLusasLine`

Using `FromLusas[Object type used in Lusas LPI]`

Would this be preferable @FraserGreenroyd?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.