BHoM / BHoM/LadybugTools_Toolkit

GetMaterialCommand and GetTypologyCommand filter should be case insensitive

Open
#339 0 comments 0 reactions 0 assignees View on GitHub
type:feature
Dominant language
Python
Stars
3
Forks
2
Avg merge
8d 20h
Merged PRs (30d)
2

Description

The nature of the Materials library means that having to search for 'concrete' means having to run the search twice, for 'concrete' and 'Concrete' to find all relevant materials. I recommend that the filter is made case insensitive to allow such searches to find all relevant results with a single command.

e.g. line 85 of GetMaterialCommand could be

```C#
return materialObjects.Where(m => (m as IEnergyMaterialOpaque).Name.ToLower().Contains(command.Filter.ToLower())).ToList();
```

Please discuss if there are any use cases where case sensitivity is necessary.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.