BHoM / BHoM/LadybugTools_Toolkit

Wind speed calculation with shelters and target wind speed

Open
#224 2 comments 0 reactions 1 assignee Claimed by @Tom-Kingstone View on GitHub
type:feature
Dominant language
Python
Stars
3
Forks
2
Avg merge
8d 20h
Merged PRs (30d)
2

Description

When running an ExternalComfort, where a typology contains both windspeed-modifying shelters and a target_wind_speed, the following happens:
- Annual wind speed is calculated based upon the epw wind speeds and the shelters
- The wind speed is then replaced with the target_wind_speed

This is possibly unintuitive. I wanted to modify the weatherfile wind speed, then have the shelters modify this new wind speed, while the current behaviour essentially ignores the effect of the shelters when setting the target_wind_speed.

I propose that, instead:
- The weatherfile wind speed is modified via the target_wind_speed
- This new wind speed is then modified as normal via the shelters.

Discussion welcome. cc @tg359

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.